Switch to compounding when consolidating with source==target #14463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
consolidation-switch-to-comp
branch
from
83e763a
to
0becec0
Compare
terencechain
force-pushed
the
consolidation-switch-to-comp
branch
from
0becec0
to
3615c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the handling of switching validators to compounding credentials by consolidating the logic into the
process_consolidation_requestflow. Key code changes include:switch_to_compounding_validatorfromprocess_pending_consolidations.switch_to_compounding_validatorfromapply_deposit.is_valid_switch_to_compounding_request.process_consolidation_requestto checkis_valid_switch_to_compounding_request, and if valid, switch the source index validator to compounding.process_consolidation_requestto automatically switch the target validator to compounding if it has an eth1 credential.Reference: ethereum/consensus-specs#3918